fix bug convert volume host path to absolute

fix ##3504 If --volume host:dest host is not a named volume, convert the host to a absolute directory path.

Signed-off-by: Qi Wang <qiwan@redhat.com>

pkg/spec/storage.go

@@ -663,10 +663,15 @@ func (config *CreateConfig) getVolumeMounts() (map[string]spec.Mount, map[string
 
 		if strings.HasPrefix(src, "/") || strings.HasPrefix(src, ".") {
 			// This is not a named volume
+			// convert src to an absolute path
+			source, err := filepath.Abs(src)
+			if err != nil {
+				return nil, nil, errors.Wrapf(err, "error getting absolute path of %s", source)
+			}
 			newMount := spec.Mount{
 				Destination: dest,
 				Type:        string(TypeBind),
-				Source:      src,
+				Source:      source,
 				Options:     options,
 			}
 			if _, ok := mounts[newMount.Destination]; ok {

pkg/spec/storage_test.go

@@ -1,25 +1,40 @@
 package createconfig
 
 import (
+	"os"
 	"testing"
 
 	spec "github.com/opencontainers/runtime-spec/specs-go"
 	"github.com/stretchr/testify/assert"
 )
 
 func TestGetVolumeMountsOneVolume(t *testing.T) {
-	data := spec.Mount{
-		Destination: "/foobar",
-		Type:        "bind",
-		Source:      "/tmp",
-		Options:     []string{"ro"},
+
+	dir, err := os.Getwd()
+	if err != nil {
+		t.Fatal(err)
+	}
+	data := map[string]spec.Mount{
+		"foobar": {
+			Destination: "/foobar",
+			Type:        "bind",
+			Source:      "/tmp",
+			Options:     []string{"ro"}},
+		"redhat": {
+			Destination: "/redhat",
+			Type:        "bind",
+			Source:      dir,
+			Options:     []string{"ro"},
+		},
 	}
 	config := CreateConfig{
-		Volumes: []string{"/tmp:/foobar:ro"},
+		Volumes: []string{"/tmp:/foobar:ro", ".:/redhat:ro"},
 	}
 	specMount, _, err := config.getVolumeMounts()
 	assert.NoError(t, err)
-	assert.EqualValues(t, data, specMount[data.Destination])
+	assert.EqualValues(t, data["foobar"], specMount["/foobar"])
+	assert.EqualValues(t, data["redhat"], specMount["/redhat"])
+
 }
 
 func TestGetTmpfsMounts(t *testing.T) {