Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to init & start podman #334

Closed
slemeur opened this issue Jul 21, 2022 · 6 comments · Fixed by #1496
Closed

Provide ability to init & start podman #334

slemeur opened this issue Jul 21, 2022 · 6 comments · Fixed by #1496
Assignees

Comments

@slemeur
Copy link
Collaborator

slemeur commented Jul 21, 2022

Is your enhancement related to a problem? Please describe

When the user is starting for the first time Podman Desktop, the setup is in 2 stages:

  • Init: to create the podman-machine
  • Start: to start the created podman-machine

Describe the solution you'd like

It would be nice if there was a button to "init and start" maybe as dropdown to choose what to do.

Describe alternatives you've considered

We may not need to give the choice to the end-user as 99% of the time, when they will want to do the init and start all together. We would then catch, by ourselves if the machine is there or stopped and do the proper actions on behalf of the user.
In the outputs, we would then display multiple steps. (inspiration could be https://material.io/archive/guidelines/components/steppers.html)

Additional context

No response

@slemeur slemeur added kind/enhancement ✨ Issue for requesting an improvement area/install 🎁 labels Jul 21, 2022
@benoitf
Copy link
Collaborator

benoitf commented Sep 15, 2022

it depends on containers/podman#14738 but it's still not fixed

benoitf added a commit to benoitf/desktop that referenced this issue Sep 27, 2022
Will help for containers#334

Change-Id: Ie282b08e56577c142346cb5a8606233d3ba16d83
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Sep 27, 2022
Will help for containers#334

Change-Id: Ie282b08e56577c142346cb5a8606233d3ba16d83
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Sep 28, 2022
Will help for #334

Change-Id: Ie282b08e56577c142346cb5a8606233d3ba16d83
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@nichjones1 nichjones1 added status/on-hold ⏸️ On hold / will revisit later and removed status/on-hold ⏸️ On hold / will revisit later labels Dec 14, 2022
@lstocchi
Copy link
Contributor

@slemeur @benoitf I was thinking about using a split button for this (similar to https://mui.com/material-ui/react-button-group/#split-button). Does it makes sense for you or you were expecting something different?

splitted_button

@lstocchi
Copy link
Contributor

@slemeur @benoitf a quick demo how it's evolving. Thoughts?

installation_demo_short

@benoitf
Copy link
Collaborator

benoitf commented Feb 15, 2023

I think this issue was flagged on hold as there will be a rewrite of the onboarding screen.
But what you're showing is what was intended.

@lstocchi
Copy link
Contributor

Oh i didn't know. As it was assigned to me last week i assumed the blocker has somehow been fixed. Do i stop it for the moment? I need to ping someone?

@slemeur
Copy link
Collaborator Author

slemeur commented Feb 15, 2023

Let's get it in. I think it's still a nice and useful improvement for end-user until we have a larger effort on the onboarding screens.

@nichjones1 nichjones1 removed the status/on-hold ⏸️ On hold / will revisit later label Feb 15, 2023
lstocchi added a commit that referenced this issue Mar 13, 2023
* feat: add split button to choose init action

Signed-off-by: luca <lstocchi@redhat.com>

* remove toggle to unify ui with buttons

Signed-off-by: luca <lstocchi@redhat.com>

* fix lint

Signed-off-by: luca <lstocchi@redhat.com>

* add buttons within list and use fa icons

Signed-off-by: luca <lstocchi@redhat.com>

* move providerinitutils to dashboard folder

Signed-off-by: luca <lstocchi@redhat.com>

* remove capitalized letter

Signed-off-by: luca <lstocchi@redhat.com>

* removed custom svelte icon components

Signed-off-by: luca <lstocchi@redhat.com>

---------

Signed-off-by: luca <lstocchi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants