enable large file upload #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isinyaaa
force-pushed
the
push-rkwtrnlwnzul
branch
from
10503c2 to
9495d5b
Compare
|
moved as Draft as mentioned, to give a chance to test "early" with b6c177f |
|
Looks it's all green 🤍 |
tarilabs
force-pushed
the
push-rkwtrnlwnzul
branch
from
b6c177f to
ea6dde7
Compare
I'd have an e2e test with a relatively larger (than the default chunk size) ML model file. I would refrain it from GB size, simply to avoid overloading the GH Actions; if anything that could become later an isolate "performance test". i.e. an e2e test with ~50MB file to start with? |
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
isinyaaa
force-pushed
the
push-rkwtrnlwnzul
branch
2 times, most recently
from
cf00b01 to
fa44a6f
Compare
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
force-pushed
the
push-rkwtrnlwnzul
branch
from
fa44a6f to
2d07947
Compare
|
Thank you so much @isinyaaa for your work upstream in oras-py and on this capability! 👍 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on the work done on oras-project/oras-py/pull/150, we got chunked upload support, which enables us to upload large files e.g. model files directly.
LMK how you'd like to test this.