Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade miekg/pkcs11 from v1.0.3 to v1.1.1 #56

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

tstromberg
Copy link
Contributor

Currently, the containers/ocicrypt library does not build on OpenBSD:

$ go test .
# github.com/miekg/pkcs11
ld: error: unable to find library -ldl
cc: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL	github.com/containers/ocicrypt [build failed]
FAIL

This PR upgrades the miekg/pkcs11 component to a version that compiles cleanly on OpenBSD. Here are the functional PR's included in the miekg/pkcs11 upgrade from v1.0.3:

For a more specific diff , see miekg/pkcs11@v1.0.3...v1.1.1

Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like to run this by @stefanberger first before merging since he is more familiar with the pkcs11 sections.

@stefanberger
Copy link
Collaborator

Hm, I hope it doesn't have any negative side effect on imgcrypt. I may try locally first, but it may take a while...

@stefanberger
Copy link
Collaborator

For a more specific diff , see miekg/pkcs11@v1.0.3...v1.1.1

I think we should be good...

@tstromberg
Copy link
Contributor Author

Excellent. Please merge this once you get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants