memtierd: update the nri-memtierd plugin to use memtierd v0.1.1 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memtierd requires to be built with go 1.22. This patch changes nri-memtierd build not to follow GO_VERSION of all the other plugins. Other options include downgrading memtierd required go version or upgrading GO_VERSION of all nri-plugins. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
klihub
previously approved these changes
Mar 15, 2024
klihub
dismissed
their stale review
@askervin: an alternative would be to pump our golang version to 1.22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memtierd requires to be built with go 1.22. This patch changes nri-memtierd build not to follow GO_VERSION of all the other plugins. Other options include downgrading memtierd required go version or upgrading GO_VERSION of all nri-plugins.