Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: don't edit/kustomize files in the repo. #224

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Jan 10, 2024

Don't kustomize/edit an in-repo kustomization.yaml file. Use a kustomization.yaml.in file instead to seed it prior to editing.

Keep a kustomization.yaml.in file in the repo instead and use that
to seed kustomization.yaml before editing it.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov fmuyassarov merged commit 0e0544b into containers:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants