topology: support more devices under /sys/devices #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
force-pushed
the
5S8_topology_more_devices
branch
from
7a6a6f8 to
36d46b3
Compare
kad
approved these changes
Dec 15, 2023
| // match /sys/devices/system/node/node0/cpulist | ||
| "cpulist": &hint.CPUs, | ||
| // match /sys/devices/pci0000:00/pci_bus/0000:00/cpulistaffinity | ||
| "cpulistaffinity": &hint.CPUs, |
There was a problem hiding this comment.
I'm not 100% sure about this one. In subfunction entries of PCI devices, the topology func should go up one layer in tree via device and should see local_cpulist entry. Have you seen scenarios where this would be more reliable compared to root function of the pci device?
Extra device support removes limitations on referring to some devices under /sys/devices in cases where referenced devices have notion of local CPUs yet the file has other name than local_cpulist. This supports e2e tests with device locality because added devices have non-trivial set of local CPUs in e2e vms. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5S8_topology_more_devices
branch
from
36d46b3 to
e6c1907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra device support removes limitations on referring to some devices under /sys/devices in cases where referenced devices have notion of local CPUs yet the file has other name than local_cpulist. This supports e2e tests with device locality because added devices have non-trivial set of local CPUs in e2e vms.