Healthcheck doc and completion fixes

[csomh]

The --healthcheck-* docs and completion has some issues in podman version 1.4.2 on Fedora 30:

• Bash completion completes --health-*. Although this would be compatible with Docker CLI (is podman still aiming for this?), the actual implementation is --healthcheck-*.
• --healthcheck-command=command is documented as --healthcheck=command.
• --no-healthcheck has currently(?) no implementation, while it's offered by bash completion.
• It's nowhere mentioned that healthchecks only work when running as root.

This change attempts to address all the above.

Let me know if any of this needs adjustment.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csomh
To complete the pull request process, please assign umohnani8
You can assign the PR to them by writing /assign @umohnani8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @csomh. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rh-atomic-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[rhatdan]

Our aim is to be compatable with Docker, So I would prefer to change the commands to match Docker commands.

      --health-cmd string              Command to run to check health
      --health-interval duration       Time between running the check
      --health-retries int             Consecutive failures needed to
                                       report unhealthy
      --health-start-period duration   Start period for the container to
                                       health-retries countdown
      --health-timeout duration        Maximum time to allow one check to
      --no-healthcheck                 Disable any container-specified

@baude PTAL

[rhatdan]

@csomh If you could open a PR to fix podman run commands to use the "Docker" equivalents, and perhaps alias the names podman chose, I think that would be the best fix.

[TomSweeneyRedHat]

bot, add author to whitelist

[baude]

there is no docker equiv. they dont do any of this outside of the dockerfile as far as I know.

[csomh]

@csomh If you could open a PR to fix podman run commands to use the "Docker" equivalents, and perhaps alias the names podman chose, I think that would be the best fix.

Sure, will do next week.

[csomh]

there is no docker equiv. they dont do any of this outside of the dockerfile as far as I know.

@baude it's possible to run:

$ docker run --health-cmd='echo 1' --health-interval=3s fedora:latest sleep 100

and see the container shown as healthy in docker ps.

$ docker --version
Docker version 1.13.1, build 1185cfd/1.13.1

The only option missing from the version above is --health-start-period (which is API 1.29+).

[baude]

cool! that is news to me!