Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI storage conf example to run manpage #2672

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Add CLI storage conf example to run manpage #2672

merged 1 commit into from
Mar 16, 2019

Conversation

TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

Add an example to the run man page to illustrate how
you can configure storage from the CLI. This addresses
a request from issue #2662.

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@TomSweeneyRedHat
Copy link
Member Author

@tobwen PTAL

@tobwen
Copy link
Contributor

tobwen commented Mar 15, 2019

@TomSweeneyRedHat LGFM, but maybe just use overlay.mount_program=/opt/fuse-overlayfs to keep the lines short? :-)

shows how to setup and use fuse-overlayfs for a one time run of busybox
using global options.

podman --log-level=debug --storage-driver overlay --storage-opt "overlay.mount_program=/home/podman/podman/usr/local/bin/fuse-overlayfs" run busybox /bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default path for fuse-overlayfs is /usr/bin/fuse-overlayfs - we might want to use that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@TomSweeneyRedHat
Copy link
Member Author

@tobwen, I went with @mheon's shortened version instead.

@tobwen
Copy link
Contributor

tobwen commented Mar 15, 2019

@TomSweeneyRedHat SIAB, LGFM, thx

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Add an example to the run man page to illustrate how
you can configure storage from the CLI.  This addresses
a request from issue #2662.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@mheon
Copy link
Member

mheon commented Mar 15, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3384bd8 into containers:master Mar 16, 2019
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/clistoreconf branch March 16, 2019 14:33
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants