--password-stdin flag in podman login
#2320
Conversation
|
Test errors look unrelated. Need updates to the man page and bash completions. The code looks good though. |
cmd/podman/login.go
Outdated
| @@ -90,6 +91,19 @@ func loginCmd(c *cliconfig.LoginValues) error { | |||
| } | |||
|
|
|||
| ctx := getContext() | |||
|
|
|||
| var password string | |||
There was a problem hiding this comment.
You wnat a function getPasswordStdin()?
| fmt.Fprint(&stdinPasswordStrBuilder, scanner.Text()) | ||
| } | ||
| password = stdinPasswordStrBuilder.String() | ||
| } |
There was a problem hiding this comment.
is there any cli validation that should occur between this flag and the password flag? exclusive?
There was a problem hiding this comment.
Please explain, what you re worried about?
There was a problem hiding this comment.
We have --password and --password-stdin - they should be mutually exclusive.
| if c.Username == "" { | ||
| return errors.Errorf("Must provide --username with --password-stdin") | ||
| } | ||
| scanner := bufio.NewScanner(os.Stdin) |
There was a problem hiding this comment.
Is there a more secure version of this? I'm thinking we probably want a version that replaces what's being typed with * so we don't display passwords as they're being typed in
There was a problem hiding this comment.
Doesn't this enable
echo MYPASSWORD | podman login --passwd-stdin
There was a problem hiding this comment.
@rhatdan Yes, it enables that
Support --password-stdin flag, reads a password from STDIN and pass it to `podman login`. Signed-off-by: Qi Wang <qiwan@redhat.com>
|
LGTM |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
github-actions
bot
added
the
locked - please file new issue/PR
Support
--password-stdinflag, reads a password from STDIN and pass it topodman login.enhancement mentioned #1675 (comment)
Signed-off-by: Qi Wang qiwan@redhat.com