Sync DNS Resolver Nameserver List #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatanugraha
force-pushed
the
main
branch
3 times, most recently
from
d8ee81b to
a5c7dc6
Compare
fatanugraha
commented
Jan 9, 2025
fatanugraha
force-pushed
the
main
branch
2 times, most recently
from
626a4a8 to
e7bf941
Compare
evidolob
approved these changes
Jan 14, 2025
|
/approve |
cfergeau
reviewed
Jan 14, 2025
fatanugraha
force-pushed
the
main
branch
2 times, most recently
from
90df25d to
0c2f9f4
Compare
|
/approve |
|
There is now a conflict in |
Signed-off-by: Fata Nugraha <fatanugraha@outlook.com>
Signed-off-by: Fata Nugraha <fatanugraha@outlook.com>
Signed-off-by: Fata Nugraha <fatanugraha@outlook.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob, fatanugraha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Any chance to have a new tagged release with this? 🙏 |
|
@AkihiroSuda we are going to make a release today |
|
The release was just done https://github.com/containers/gvisor-tap-vsock/releases/tag/v0.8.2 |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lima-vm/lima](https://github.com/lima-vm/lima) | patch | `v1.0.3` -> `v1.0.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lima-vm/lima (lima-vm/lima)</summary> ### [`v1.0.4`](https://github.com/lima-vm/lima/releases/tag/v1.0.4) [Compare Source](lima-vm/lima@v1.0.3...v1.0.4) #### Changes - network: - Use MAC address as dhcpd identifier ([#​3123](lima-vm/lima#3123), thanks to [@​nirs](https://github.com/nirs)) - Updated gvisor-tap-vsock to v0.8.2 to [fix a DNS issue](containers/gvisor-tap-vsock#450) ([#​3133](lima-vm/lima#3133)) - YAML: - Un-deprecate non-strict YAML ([#​3104](lima-vm/lima#3104), thanks to [@​jandubois](https://github.com/jandubois)) - nerdctl: - Updated from v2.0.1 to [v2.0.3](https://github.com/containerd/nerdctl/releases/tag/v2.0.3) ([#​3134](lima-vm/lima#3134)) - Templates: - Updated to the latest revisions ([#​3134](lima-vm/lima#3134)) Full changes: https://github.com/lima-vm/lima/milestone/54?closed=1 Thanks to [@​afbjorklund](https://github.com/afbjorklund) [@​alexandear](https://github.com/alexandear) [@​jandubois](https://github.com/jandubois) [@​nirs](https://github.com/nirs) [@​olamilekan000](https://github.com/olamilekan000) [@​paulinek13](https://github.com/paulinek13) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/12899702091 The sha256sum of the SHA256SUMS file itself is `05b809c6e23fa411fd6987c4fab1ceccb8efda36241130cc5269ba746a2a7762` . *** Release manager: [@​AkihiroSuda](https://github.com/AkihiroSuda) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjIuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEyMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gvisor-tap-vsock only reads the
/etc/resolv.confduring init time and does not subscribe into the changes that is made on that file. That is fine, but if i start gvisor-tap-vsock before I connected to my work VPN (which modifies /etc/resolv.conf) after I connected to the VPN i will no longer be able to resolve any DNS queries made from my VM because the original IP that gvisor-tap-vsock is using is no longer reachable once I connected to my work VPN.gvisor-tap-vsock log:
In this PR, I added functionality to ensure that the nameservers that we use to resolve DNS queries are up-to-date with the content of the
/etc/resolv.conf