Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interrupted pending writes on socket write shutdown from eager close #162

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix interrupted pending writes on socket write shutdown from eager close #162

merged 1 commit into from
Dec 5, 2022

Commits on Dec 5, 2022

  1. Fix interrupted pending writes on socket write shutdown from eager close 

    Some channel/connection implementations may signal EOF to parallel
readers before tasks related to the CloseWrite (shutdown) have
completed progressing. This creates the potential for a race with
a parallel Close(), leading to a premature abort of certain activies
(cancelling the send of buffered data).

This change ensures that the two goroutines copying each direction
of the stream wait until CloseWrite has completed in both directions
before fully closing.

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
    @n1hility
    n1hility committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    db11bd9 View commit details
    Browse the repository at this point in the history