-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor in latest containers/(storage, image) #1255
Conversation
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@edsantiago PTAL |
@mtrmac @vrothberg @flouthoc @mheon PTAL |
Fixing the GetLockfile -> GetLockFile bit in Podman is going to be fun. LGTM |
/hold We need an accompanying PR against Podman. Otherwise, we cannot vendor-in c/common until that is fixed which will potentially block other work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrothberg I am working this through the entire process to get there. I plan on working this through into Buildah and then into Podman. I also have PR for containers/image opened. |
BTW Nothing is breaking except for linters complaining about depracated interfaces. |
PR Opened containers/podman#16744 |
That exists in containers/podman#16581 ; if that is merged, then c/common can be vendored, or not, into Podman at any unrelated time. (It’s also still an option to remove the deprecation annotation from c/storage’s |
Since storage was merged into Podman, I am merging this. |
Signed-off-by: Daniel J Walsh dwalsh@redhat.com