Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] TMT: system tests #5885

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 20, 2024

This commit adds TMT jobs for system tests triggered via Packit for all active Fedora and CentOS Stream releases on x86_64.

TODO: enable aarch64 tests.

Official Fedora and CentOS Stream spec and gating test configs can be synced from upstream by Packit, effectively upstreaming almost all mainteenance.

What type of PR is this?

/kind other

What this PR does / why we need it:

Runs system tests using TMT. This test setup can be reused for official Fedora and CentOS-Stream packages as well as reused for upstream reverse dependency testing in c/common.

How to verify it

TMT tests in CI list.

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[4].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[6].packages': 'Undefined package(s) referenced: podman-centos.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-centos.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[4].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[6].packages': 'Undefined package(s) referenced: podman-centos.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-centos.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[4].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[6].packages': 'Undefined package(s) referenced: podman-centos.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-centos.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@lsm5 lsm5 force-pushed the tmt-system-tests branch 7 times, most recently from bf833e8 to e9a0088 Compare December 24, 2024 11:02
@lsm5
Copy link
Member Author

lsm5 commented Dec 24, 2024

/packit retest

@lsm5
Copy link
Member Author

lsm5 commented Dec 24, 2024

/packit test

@lsm5 lsm5 force-pushed the tmt-system-tests branch 3 times, most recently from 1a74573 to 7b52fe4 Compare December 25, 2024 10:05
@lsm5 lsm5 force-pushed the tmt-system-tests branch 3 times, most recently from 2c7daef to 429c88f Compare January 20, 2025 10:09
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2025
@lsm5 lsm5 force-pushed the tmt-system-tests branch from 429c88f to 2a2c4bf Compare February 4, 2025 12:52
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@lsm5 lsm5 force-pushed the tmt-system-tests branch from 2a2c4bf to a2503ff Compare February 4, 2025 13:00
@lsm5
Copy link
Member Author

lsm5 commented Feb 4, 2025

@flouthoc @nalind we're not testing on aarch64 yet are we?

some of the testing-farm-*-aarch64 tests added in this PR are failing on linux/arm64 vs linux/amd64 and some cases are warning on it and failing like so:

# # /usr/bin/buildah commit --signature-policy /usr/share/buildah/test/system/policy.json time="2025-02-04T13:50:22Z" level=warning msg="image platform (linux/amd64) does not match the expected platform (linux/arm64)" testdigest_v2s2-working-container new-image
# Error: too many arguments specified
# [ rc=125 (** EXPECTED 0 **) ]

@nalind
Copy link
Member

nalind commented Feb 4, 2025

@flouthoc @nalind we're not testing on aarch64 yet are we?

some of the testing-farm-*-aarch64 tests added in this PR are failing on linux/arm64 vs linux/amd64 and some cases are warning on it and failing like so:

# # /usr/bin/buildah commit --signature-policy /usr/share/buildah/test/system/policy.json time="2025-02-04T13:50:22Z" level=warning msg="image platform (linux/amd64) does not match the expected platform (linux/arm64)" testdigest_v2s2-working-container new-image
# Error: too many arguments specified
# [ rc=125 (** EXPECTED 0 **) ]

We're not testing on aarch64 - this looks like a previous line in the test that wanted to capture the ID of a newly-created working container captured the whole line time="2025-02-04T13:50:22Z" level=warning msg="image platform (linux/amd64) does not match the expected platform (linux/arm64)" as its name.

@nalind
Copy link
Member

nalind commented Feb 4, 2025

Oh, I guess the testing farm is testing natively on non-amd64. Nice!

@lsm5 lsm5 force-pushed the tmt-system-tests branch from a2503ff to 52c82c8 Compare February 5, 2025 10:50
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc
Copy link
Collaborator

/hold

@flouthoc
Copy link
Collaborator

@nalind PTAL

@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2025
@lsm5
Copy link
Member Author

lsm5 commented Feb 24, 2025

@nalind PTAL

@lsm5 lsm5 force-pushed the tmt-system-tests branch 3 times, most recently from 958adb8 to 5f2f570 Compare February 28, 2025 10:21
@nalind
Copy link
Member

nalind commented Feb 28, 2025

I don't love that this scatters files throughout our tree, but it's probably too late to enforce that for every out-of-tree integration.
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 28, 2025
@lsm5 lsm5 force-pushed the tmt-system-tests branch from 5f2f570 to b488a70 Compare March 3, 2025 09:22
@openshift-ci openshift-ci bot removed the lgtm label Mar 3, 2025
@lsm5
Copy link
Member Author

lsm5 commented Mar 3, 2025

/packit build
/packit test

@lsm5
Copy link
Member Author

lsm5 commented Mar 3, 2025

Needed a rebase .

@nalind PTAL . Thanks.

@nalind
Copy link
Member

nalind commented Mar 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 3, 2025
@lsm5
Copy link
Member Author

lsm5 commented Mar 4, 2025

Looks like this PR gets outdated by the time it gets a slash-lgtm so merges are blocked 😄 . I'll rebase it once again.

This commit adds TMT jobs for system tests triggered via Packit for
all active Fedora and CentOS Stream releases on x86_64.

TODO: enable aarch64 tests.

Official Fedora and CentOS Stream spec and gating test configs can be
synced from upstream by Packit, effectively upstreaming almost all
mainteenance.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 force-pushed the tmt-system-tests branch from b488a70 to c54e43a Compare March 4, 2025 10:53
@openshift-ci openshift-ci bot removed the lgtm label Mar 4, 2025
@nalind
Copy link
Member

nalind commented Mar 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2025
@lsm5
Copy link
Member Author

lsm5 commented Mar 4, 2025

/hold cancel

Thanks @nalind

@openshift-merge-bot openshift-merge-bot bot merged commit ae1e1d5 into containers:main Mar 4, 2025
39 of 40 checks passed
@lsm5 lsm5 deleted the tmt-system-tests branch March 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants