Move DiscoverContainerfile to define directory, so podman can use it

[rhatdan]

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nalind]

The point of moving type definitions into this directory is to avoid having consumers build code that they might not end up calling, and this seems to run counter to that goal. Somewhere under pkg or in the util grab bag would be more appropriate.

[TomSweeneyRedHat]

If @nalind likes the location, the changes LGTM. Tests aren't happy yet though.

[nalind]

I don't love it (why must it be added in an existing import path?), but it's not a hill I'm particularly interested in dying on. Either way, the commit message and pull request name need to be updated.

[rhatdan]

@nalind Moved it to pkg/util

[TomSweeneyRedHat]

@rhatdan the smoke test is smoking

[nalind]

Needs to add pkg/util/*.go to the SOURCES list in the top-level Makefile, then LGTM.

[TomSweeneyRedHat]

@rhatdan looks like a rebase is wanted.