Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: use the correct error for errors.Wrapf #2559

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

giuseppe
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
improve the error message by including the command stdout, if any.
Stderr is already handled.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@TomSweeneyRedHat
Copy link
Member

I preferred the stateErr name, but ¯_(ツ)_/¯
LGTM
and happy green test buttons

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 22, 2020

Build succeeded:

  • cirrus-ci/success

@bors bors bot merged commit 9996223 into containers:master Aug 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants