docs/logically-bound: A bit more docs #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrero
reviewed
Aug 2, 2024
| ## Limitations | ||
|
|
||
| - Currently, only the Image field of a `.image` or `.container` file is used to pull the image; per above not even `PullSecret=` is supported. | ||
| - Images are not yet garbage collected | ||
| - The Image field of a `.image` or `.container` file is used to pull the image; this is the old field that is used. |
There was a problem hiding this comment.
generally lgtm, however something in the last sentence confuses me. this is the old field that is used. after saying that the current way is .image or .container is how we pull the image makes me confused about what are you referring to as the old field here.
There was a problem hiding this comment.
That sentence was just a corrupted mix of the old text and my attempt to update it, thanks for catching it!
Fixed.
cgwalters
force-pushed
the
more-lbi-docs
branch
from
7d52edf
to
6909ab5
Compare
Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
more-lbi-docs
branch
from
6909ab5
to
89b4f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.