Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add centos stream 10 rpm build and e2e test #743

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

henrywang
Copy link
Contributor

This PR includes:

  1. add centos stream 10 all arch rpm build
  2. add e2e test for centos stream 10

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, though one issue is the matrix here is getting pretty large, and fairly often we hit "artemis" provisioning failures e.g.

"systemd.unified_cgroup_hierarchy=0" does not work with CS10
It caused boot failure with error:
[!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel
command line.

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
SOURCE can be overlay, none or composefs

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@henrywang
Copy link
Contributor Author

henrywang commented Aug 1, 2024

Hi @lukewarmtemp, I found systemd.unified_cgroup_hierarchy=0 was added in PR #594.

I have to remove it in this PR because it caused boot failure on CS10 with error: [!!!!!!] Refusing to run under cgroup v1, SY… specified on kernel command line. CS10 deprecated boot from cgruop v1.

I there any test impact of remove this karg? Thanks.

@lukewarmtemp
Copy link
Contributor

I there any test impact of remove this karg? Thanks.

You're free to remove it. Sorry, I just arbitrarily chose some kargs to test and didn't realize that it might conflict with others.

@cgwalters
Copy link
Collaborator

Yes, we should definitely not set that.

@henrywang
Copy link
Contributor Author

Looks sane, though one issue is the matrix here is getting pretty large, and fairly often we hit "artemis" provisioning failures e.g.

Yes. The most of time (99%) the provisioning issue happens on x86_64 runner machine. Looks the aarch64 runner does not hit the quota.

  • In to-disk test, I removed centos-stream-9-x86_64 and added centos-stream-10-x86_64. No additional x86_64 test added.
  • I added centos-stream-10-aarch64 in both to-disk and to-existing-root tests.

@henrywang henrywang marked this pull request as ready for review August 1, 2024 15:24
@henrywang henrywang merged commit 12828ea into containers:main Aug 1, 2024
34 checks passed
@henrywang henrywang deleted the cs10 branch August 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants