Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Work around bootc-image-builder using /run/osbuild/containers #737

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

cgwalters
Copy link
Collaborator

install: Factor out an osbuild module

Unfortunately the interactions/workarounds here are going to grow, so make
a module to encapsulate them.

Signed-off-by: Colin Walters walters@verbum.org


install: Work around bootc-image-builder using /run/osbuild/containers

xref: osbuild/bootc-image-builder#560

Basically osbuild/bib puts the host /var/lib/containers at
/run/osbuild/containers. If we detect this situation, bind
mount it to /var/lib/containers so that the container
stack we invoke at install time can find logically bound
images.

Closes: #715

Signed-off-by: Colin Walters walters@verbum.org


Unfortunately the interactions/workarounds here are going to grow, so make
a module to encapsulate them.

Signed-off-by: Colin Walters <walters@verbum.org>
xref: osbuild/bootc-image-builder#560

Basically osbuild/bib puts the host `/var/lib/containers` at
`/run/osbuild/containers`. If we detect this situation, bind
mount it to `/var/lib/containers` so that the container
stack we invoke at install time can find logically bound
images.

Closes: containers#715

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit a947c9d into containers:main Jul 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bound images fail in bootc-image-builder
2 participants