install: Fork blockdev --rereadpt instead of internal ioctl
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ioctl` to reread the partition table was the last thing pulling in `nix`. Honestly especially in the install path I have no problem forking external binaries, and since we're already depending on util-linux-core for other things like `sfdisk` and `lsblk`, it just makes sense to so here with the command whose entire role in life is to just issue that `ioctl`. This drops out an older verison of `nix` (which is a fine crate, but again I think `rustix` is nicer). There's a different version pulled in via libsystemd, but we can get to that later. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ioctlto reread the partition table was the last thing pulling innix. Honestly especially in the install path I have no problem forking external binaries, and since we're already depending on util-linux-core for other things likesfdiskandlsblk, it just makes sense to so here with the command whose entire role in life is to just issue thatioctl.This drops out an older verison of
nix(which is a fine crate, but again I thinkrustixis nicer). There's a different version pulled in via libsystemd, but we can get to that later.