install/baseline: use sfdisk, not lsblk #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
baseline-sfdisk
branch
from
f735c53
to
136e695
Compare
jeckersb
reviewed
Jul 17, 2024
Signed-off-by: Colin Walters <walters@verbum.org>
I think this may also help with the install flake we've been seeing where we somehow get the partitions mixed up. - Use `sfdisk` in the baseline install because it's what we're switching to using anyways later on - Add some verification at least for the root and EFI partitions that we read back the expected type Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
force-pushed
the
baseline-sfdisk
branch
from
136e695
to
ad0647b
Compare
|
Nevermind it was me, it just shows up weird in the github UI when I push to your branch |
jeckersb
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may also help with the install flake we've been
seeing where we somehow get the partitions mixed up.
sfdiskin the baseline install because it's whatwe're switching to using anyways later on
that we read back the expected type