boundimage: Drop duplicate filenames from errors #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two minor things: - I think it's cleanest to separate parsing from files; we were passing the file name to the parser just to include it in the error message - We had the file path *twice* in errors (once in the context, once in the returned error) Fix both these things by using `with_context` that includes the path in the callers. So the resulting error should look like e.g. `Parsing /usr/lib/bootc/bound-images.d/foo.image: Missing Image field` or so. Signed-off-by: Colin Walters <walters@verbum.org>
ckyrouac
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor things:
Fix both these things by using
with_contextthat includes the path in the callers.So the resulting error should look like e.g.
Parsing /usr/lib/bootc/bound-images.d/foo.image: Missing Image fieldor so.