bugfix: Switch losetup to --direct-io=off by default #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Apr 25, 2024
lib/src/blockdev.rs
Outdated
Comment on lines
87
to
96
| let direct_io = match env::var("BOOTC_DIRECT_IO") { | ||
| Ok(val) => { | ||
| if val == "on" { "on" } else { "off" } | ||
| }, | ||
| Err(_e) => { | ||
| "off" | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Hmm, it seems simpler to pass through the variable if present directly to the command...something like:
let direct_io_arg = env::var_os("BOOTC_INSTALL_DIRECT_IO").map(|v| format!("--direct-io={v:?}");
...
.args(["--show", "-P", "--find"])
.arg(direct_io_arg)
or so? (not tested)
cgwalters
approved these changes
Apr 25, 2024
|
I'm ok with this as too, but missing a |
When using a loopback device pointing to a file on a 9p filesystem (e.g. the home mount of a podman machine), using direct-io=on causes the partitioning via sgdisk to fail. This is a temporary fix until podman machine switches away from 9p or another fix is found. Direct IO can be enabled via the BOOTC_DIRECT_IO=on environment variable. Fixes containers#485 Signed-off-by: Chris Kyrouac <ckyrouac@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a loopback device pointing to a file on a 9p filesystem (e.g. the home mount of a podman machine), using direct-io=on causes the partitioning via sgdisk to fail. This is a temporary fix until podman machine switches away from 9p or another fix is found. Direct IO can be enabled via the BOOTC_DIRECT_IO=on environment variable.
Fixes #485