-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace rootless #414
Trace rootless #414
Conversation
Previously this was just always None via Default. Also updated trace logging to show the entire container_info struct. All of those fields are potentially useful, not just engine. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
This will catch rootless podman cases even more reliably (assuming we were invoked with `--pid=host`). Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity checked this catches the case I was seeing:
⬢[jeckersb@toolbox ~]$ env BOOTC_INSTALL_LOG=trace podman-bootc run quay.io/jeckersb/centos-bootc-jeckersb:latest
TRACE starting
TRACE Preparing install
TRACE Verified uid 0 with CAP_SYS_ADMIN
TRACE OK: we're not pid 1
ERROR Installing to disk: /proc/1 is owned by 65534, not zero; this command must be run in the root user namespace (e.g. not rootless podman)
Error: unable to install bootc image: failed to create disk image: failed to run bootc install
Test failure looks like an AWS flake?
|
Yeah, right now we aren't always gating on these, though we probably should. But...I would also like to change the testing framework to inject testing code into the OS image, instead of being ssh-push based as it is now. The former is much more in line with the philosophy here 😄 |
This builds on #413
This will catch rootless podman cases even more reliably (assuming
we were invoked with
--pid=host
).