[CI:TOOLING] Increase obsolete image flagging and pruning #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `uuidgen` tool has long-since been removed from the tooling images. For whatever reason one call to it still existed. Remove it. Signed-off-by: Chris Evich <cevich@redhat.com>
|
@edsantiago PTAL when you get a chance, this isn't super urgent. Note: I'm aware the commits & messages are wonky (I thought the 500+ in the logs showed candidates not totals). I'll fix up the commits after you are able to take a look. |
|
LGTM |
It was observed in the Cirrus-CI cron logs, that only the total number of images scanned is reported. Fix this by giving more useful info., like the number of candidates for obsolete/pruning. Related, the original restriction of `10` obsolete/prune images was originally put in place when only a few repos utilized Cirrus-CI VMs and image building was substantially more infrequent. The reason it exists is to prevent potential catastrophe should the `meta` time stamp updating tasks have a bug or some other related failure occur. Increase the limit to `50` so deletions may proceed much more rapidly. *Note:* "Obsolete" images still live w/in a 30-day window where they can be recovered if need be. It's simply that any attempted use by CI will fail, putting someone on notice that image recovery may be necessary. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
increase_image_rm_rate
branch
from
3252adb
to
f67769a
Compare
|
Force-push: No code changes, just commit/message cleanup. |
|
LGTM again, merge at will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase obsolete image flagging and pruning
It was observed in the Cirrus-CI cron logs, that only the total
number of images scanned is reported. Fix this by giving more
useful info., like the number of candidates for obsolete/pruning.
Related, the original restriction of
10obsolete/prune imageswas originally put in place when only a few repos utilized Cirrus-CI
VMs and image building was substantially more infrequent. The
reason it exists is to prevent potential catastrophe should the
metatime stamp updating tasks have a bug or some other related failure occur.
Increase the limit to
50so deletions may proceed much more rapidly.Note: "Obsolete" images still live w/in a 30-day window where they can
be recovered if need be. It's simply that any attempted use by CI will
fail, putting someone on notice that image recovery may be necessary.