[v1.10.0-rhel] Don't tear down all server threads on SIGHUP #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of 1f96f76 Instead we parse the new config, replace the in-memory configuration state, stop all old threads for IPs which are no longer in the configuration, and start any new ones for IPs which were added. Paul: Fixing merge conflicts in Cargo.toml and bumping time because that no 13 longer builds on rust v1.80 Fixes https://issues.redhat.com/browse/RHEL-59129 Fixes https://issues.redhat.com/browse/ACCELFIX-287 Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
@TomSweeneyRedHat PTAL, are these the right Jira links I added? |
|
@Luap99, sorry, I just saw this. Those are the right links. The RHEL one should suffice, but I prefer putting both on PR like you did. |
|
Not a Rust expert by any means, but the backport looks like a mirror image. LGTM |
|
@mheon PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 68d9dad
into
containers:v1.10.0-rhel
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we parse the new config, replace the in-memory configuration state, stop all old threads for IPs which are no longer in the configuration, and start any new ones for IPs which were added.
Paul:
Fixing merge conflicts in Cargo.toml and bumping time because that no longer builds on rust v1.80
Fixes https://issues.redhat.com/browse/RHEL-59129
Fixes https://issues.redhat.com/browse/ACCELFIX-287