Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to ignore YouTube and Google Search Pages #43

Conversation

berrnd
Copy link
Contributor

@berrnd berrnd commented Mar 24, 2019

First: Thanks for this great Firefox extension! :)

I wanted to have two additions to fit what I wanted:

  • Ignore YouTube - I don't want to be logged into Google when using YouTube
  • Ignore Search Pages - I don't want to be logged into Google for searches (includes Maps and Flights search)

The first was already done by hard removing the YOUTUBE_DOMAINS: Repo & AMO AddOn

The later I did today by also hard coding this (done by URL path matching): Repo & AMO AddOn

I thought maybe this is useful for others too and added both things in an optional way.

Technically this maybe could be done better, but I found no proper way to do it right:

  • When ignoring YouTube, it would be enough to exclude the YouTube domains when concating all domains together at the top of the script
  • The path match for excluding search pages should be maybe better limited to GOOGLE_DOMAINS and GOOGLE_INTL_DOMAINS, currently checks all domains

(But it works... :D)

Ignore YouTube (to not being logged into Google on YouTube, originally done by https://github.com/yoasif/contain-google-minus-youtube, but without having that optionally)
Ignore search pages (to not being logged into Google for Google searches, includes maps and flight search)
@Perflyst
Copy link
Collaborator

Thank you for this pull request. I wanna play around with this first (and how it works together with MAC or TC), but will probably get merge.

FYI:

I don't want to be logged into Google when using YouTube

Nobody who cares about privacy should ever use youtube.com again. There is https://invidio.us and other instances who host Invidious which you can use.

@berrnd
Copy link
Contributor Author

berrnd commented Mar 24, 2019

Thanks for the fast response.

Nobody who cares about privacy should ever use youtube.com again. There is https://invidio.us and other instances who host Invidious which you can use.

Sure, everything in that game is about comfort vs privacy - I also don't want to use Google for searching the web, is possible, somehow, tried that for 2 weeks not long ago - unfortunately the experiment failed for me (yes, including using a meta search engine like searx)...

@berrnd
Copy link
Contributor Author

berrnd commented Mar 25, 2019

I've optimized the changes from yesterday a little bit...

(Use regex for search page pathname comparison, moved the checks into shouldContainInto function to have it more structured.)

@Perflyst Perflyst merged commit 1fc0603 into containers-everywhere:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants