Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebase #27

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Add Firebase #27

merged 1 commit into from
Sep 8, 2018

Conversation

bgiesing
Copy link
Contributor

@bgiesing bgiesing commented Sep 6, 2018

firebaseapp.com not being in the container breaks Google sign-in on some Google (and non-Google) owned websites as they use a domain like gpp-oauth-client.firebaseapp.com to auth (like Google's Opinion Rewards Panel)


This change is Reviewable

@Perflyst
Copy link
Collaborator

Perflyst commented Sep 8, 2018

Thank you

@Perflyst Perflyst merged commit bfac884 into containers-everywhere:master Sep 8, 2018
@bgiesing bgiesing mentioned this pull request Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants