Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call ipam.ExecDel after clean up device in netns #702

Merged
merged 1 commit into from
Mar 2, 2022
Merged

call ipam.ExecDel after clean up device in netns #702

merged 1 commit into from
Mar 2, 2022

Conversation

gojoy
Copy link
Contributor

@gojoy gojoy commented Feb 14, 2022 •
edited
Loading

call ipam.ExecDel to release ip in ipam after clean up device in netns.,avoid ip conflict
fix #666

Signed-off-by: gojoy 729324352@qq.com

@gojoy gojoy marked this pull request as ready for review February 14, 2022 03:04
dcbw
dcbw reviewed Feb 16, 2022
View reviewed changes
plugins/main/bridge/bridge.go Outdated Show resolved Hide resolved
@gojoy gojoy changed the title call ipam.ExceDel after clean up device in netns call ipam.ExecDel after clean up device in netns Feb 17, 2022
@gojoy gojoy requested a review from dcbw February 17, 2022 06:19
@dcbw
Copy link
Member

dcbw commented Feb 23, 2022

@gojoy could squash the new commit into the first one, so that the DCO is OK?

@dcbw
Copy link
Member

dcbw commented Feb 23, 2022

@gojoy and can you git rm the bridge plugin binary that seems to have crept into the commit?

@gojoy
Copy link
Contributor Author

gojoy commented Feb 27, 2022

@gojoy could squash the new commit into the first one, so that the DCO is OK?

done

@gojoy
Copy link
Contributor Author

gojoy commented Feb 27, 2022

@gojoy and can you git rm the bridge plugin binary that seems to have crept into the commit?

done

@dcbw
Copy link
Member

dcbw commented Mar 2, 2022

/lgtm

@squeed
Copy link
Member

squeed commented Mar 2, 2022

lgtm, thanks

@dcbw dcbw merged commit b8a10bb into containernetworking:master Mar 2, 2022
@squeed squeed mentioned this pull request Mar 9, 2022
Merged
EmilyShepherd added a commit to EmilyShepherd/kiOS that referenced this pull request Dec 10, 2022
@EmilyShepherd
Add patch to revert bridge shutdown behaviour
af3ec5f 
[This change][upstream] originally caused the bridge to clean up the
interface before calling the DHCP plugin to clean up.

Unfortuneately, this caused an error as DHCP requires the interface to
still exist so it can release the IP address to the DHCP server.

This patch reverts it as it is required in kios. Please see [the
upstream issue][issue] for further discussion on this.

[upstream]: containernetworking/plugins#702
[issue]: containernetworking/plugins#791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bridge plugin:call ipam.ExecDel after clean device in netns
3 participants
@gojoy @dcbw @squeed