dhcp ipam: support customizing dhcp options from CNI args #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Almost every first retry of DHCP will fail due to interface is not up. Add a fast retry to reduce unnecessary latency. Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
SilverBut
changed the title
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
First byte of client ID is type, instead of value. See this from RFC2132: Code Len Type Client-Identifier +-----+-----+-----+-----+-----+--- | 61 | n | t1 | i1 | i2 | ... +-----+-----+-----+-----+-----+--- Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
|
/lgtm |
|
looks good |
mars1024
reviewed
Nov 23, 2021
| clientID := containerID + "/" + netName + "/" + ifName | ||
| // defined in RFC 2132, length size can not be larger than 1 octet. So we truncate 254 to make everyone happy. | ||
| if len(clientID) > 254 { | ||
| clientID = clientID[0:254] |
There was a problem hiding this comment.
IMO, containerID and ifName are enough to be composed as clientID.
There was a problem hiding this comment.
This is actually not changed to ensure backward compatibility, since I'm not sure if anyone is using this default config in somewhere of their config...
dcbw
reviewed
Nov 24, 2021
Signed-off-by: SilverBut <SilverBut@users.noreply.github.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some DHCP options sent to the server can be set from parsing CNI_ARGS.
This closes #435 and #660.