Support device id in host device plugin #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Chiris <adrianc@mellanox.com>
Signed-off-by: Adrian Chiris <adrianc@mellanox.com>
adrianchiris
force-pushed
the
support-device-id-host-device
branch
from
a2dff63 to
2e7e92d
Compare
|
related to PR : containernetworking/cni#761 |
mars1024
reviewed
Apr 8, 2020
|
Could you help to add some comments in |
|
@mars1024 sure |
mars1024
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
/lgtm, but before merging this, you need to update DCO @adrianchiris
|
/lgtm |
|
@adrianchiris can you add your signed-off-by DCO? Thanks! |
|
lgtm. Can you amend your commit with a Signed-Off-By so DCO passes, then we can merge this? |
Signed-off-by: Adrian Chiris <adrianc@mellanox.com>
adrianchiris
force-pushed
the
support-device-id-host-device
branch
from
fd3169a to
3e3ffde
Compare
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.