Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert htb changes due to ongoing issues and missing maintainer #1105

Merged
merged 4 commits into from
Oct 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add problem hint
Signed-off-by: h0nIg <h0nIg@users.noreply.github.com>
h0nIg committed Oct 11, 2024

Verified

This commit was signed with the committer’s verified signature.
wichtounet Baptiste Wicht
commit 0237bd131a01609f5bdb92d6a4fd21fd2e939ae6
9 changes: 6 additions & 3 deletions plugins/meta/bandwidth/ifb_creator.go
Original file line number Diff line number Diff line change
@@ -27,11 +27,14 @@ import (
const latencyInMillis = 25

func CreateIfb(ifbDeviceName string, mtu int) error {
// do not set TxQLen > 0 nor TxQLen == -1 until issues have been fixed with numrxqueues / numtxqueues across interfaces
// which needs to get set on IFB devices via upstream library: see hint https://github.com/containernetworking/plugins/pull/1097
err := netlink.LinkAdd(&netlink.Ifb{
LinkAttrs: netlink.LinkAttrs{
Name: ifbDeviceName,
Flags: net.FlagUp,
MTU: mtu,
Name: ifbDeviceName,
Flags: net.FlagUp,
MTU: mtu,
TxQLen: 0,
},
})
if err != nil {