Pass status along ipam update #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Aug 27, 2024
| } | ||
| } | ||
|
|
||
| // TODO: Check if hode device exists. |
There was a problem hiding this comment.
This is awkward -- you're right, the host device does not exist anymore, but it may have been moved with an ADD. I worry this could cause more trouble than its worth. Hmm.
There was a problem hiding this comment.
I fixed the miss-spelling.
The idea comes from this comment: #1021 (comment)
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
from
a33a4c8 to
aea27c7
Compare
|
@LionelJouin you need to be rebase |
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
2 times, most recently
from
044df64 to
c5883a2
Compare
|
@LionelJouin needs another rebase :-) |
|
@LionelJouin somehow this PR still does not have the green button. Perhaps the latest changes to Can you rebase and drop your merge commit? That helps keep the history clean. |
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
from
212689b to
79b1e5e
Compare
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
2 times, most recently
from
b540e47 to
ef665d3
Compare
squeed
approved these changes
Sep 30, 2024
|
I saw the tests of the VRF plugin are also flaky, I haven't looked into them yet. |
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
2 times, most recently
from
71acd07 to
1a3f6a2
Compare
Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
LionelJouin
force-pushed
the
pass-status-along-ipam-update
branch
from
1a3f6a2 to
b034c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing parts of #1050 (pass STATUS to a delegated plugin)
I also updated the cni dependency to v1.2.3