Fix unnecessary retrying when the link is down in dhcp #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the test failure is not relative to this pr ? 🤔 |
From the dhcp daemon log, we can see that dhcp will fail to acquire the lease when the link is down, and success on retry. ``` 2024/08/21 21:30:44 macvlan-dhcp/eth1: acquiring lease 2024/08/21 21:30:44 Link "eth1" down. Attempting to set up 2024/08/21 21:30:44 network is down 2024/08/21 21:30:44 retrying in 2.641696 seconds 2024/08/21 21:30:49 macvlan-dhcp/eth1: lease acquired, expiration is 2024-08-22 09:30:49.755367962 +0800 CST m=+43205.712107889 ``` After move the code of set up link to the beginning of the function, the dhcp success on first time. ``` 2024/08/21 22:04:02 macvlan-dhcp/eth1: acquiring lease 2024/08/21 22:04:02 Link "eth1" down. Attempting to set up 2024/08/21 22:04:05 macvlan-dhcp/eth1: lease acquired, expiration is 2024-08-22 10:04:05.297887726 +0800 CST m=+43203.081141304 ``` Signed-off-by: Songmin Li <lisongmin@protonmail.com>
squeed
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the dhcp daemon log, we can see that dhcp will fail to acquire the lease when the link is down, and success on retry.
After move the code of set up link to the beginning of the function, the dhcp success on first time.