Skip to content

Commit

Permalink
fix(dhcp): can not renew an ip address
Browse files Browse the repository at this point in the history
The dhcp server is systemd-networkd, and the dhcp
plugin can request an ip but can not renew it.
The systemd-networkd just ignore the renew request.

```
2024/09/14 21:46:00 no DHCP packet received within 10s
2024/09/14 21:46:00 retrying in 31.529038 seconds
2024/09/14 21:46:42 no DHCP packet received within 10s
2024/09/14 21:46:42 retrying in 63.150490 seconds
2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: no more tries
2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: renewal time expired, rebinding
2024/09/14 21:47:45 Link "eth1" down. Attempting to set up
2024/09/14 21:47:45 98184616c91f15419f5cacd012697f85afaa2daeb5d3233e28b0ec21589fb45a/iot/eth1: lease rebound, expiration is 2024-09-14 22:47:45.309270751 +0800 CST m=+11730.048516519
```

Follow the https://datatracker.ietf.org/doc/html/rfc2131#section-4.3.6,
following options must not be sent in renew

- Requested IP Address
- Server Identifier

And renew should using unicast but not broadcast.

Signed-off-by: Songmin Li <lisongmin@protonmail.com>
  • Loading branch information
lisongmin committed Sep 14, 2024
1 parent 01b3db8 commit 7961199
Showing 1 changed file with 33 additions and 33 deletions.
66 changes: 33 additions & 33 deletions vendor/github.com/d2g/dhcp4client/client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7961199

Please sign in to comment.