-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default out_dir support #262
Conversation
@jokemanfire The feature is useful, and I think we'd better not update the example because I occasionally need to check the generated code and out_dir is not easy to find. By the way, please take a look at the failed CI, thanks |
dbda636
to
ea662c5
Compare
Ok ,I've changed and add usage in doc. |
@jokemanfire I left a new comment, PTAL, thanks |
4199a48
to
5b5cbcd
Compare
CI now have some problem need update rustc version ??? |
43fa5e8
to
b50d83a
Compare
@jokemanfire After the pr #267 was merged, the rustc verstion problem has disappeared. Please rebase and remove the fix commit. thanks |
Ok I've update |
@jokemanfire I left comments again. PTAL, thanks. |
If not set out_dir,it will use env 'OUT_DIR',to generate proto rs file. You can use 'include!' marco to include env 'OUT_DIR' proto rs . Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
If not set out_dir,it will use env 'OUT_DIR' to generate proto rs file.You can use 'include!' marco to include env 'OUT_DIR' proto rs .
And you needn't to create a dir in your source dir.