Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default out_dir support #262

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jokemanfire
Copy link
Contributor

If not set out_dir,it will use env 'OUT_DIR' to generate proto rs file.You can use 'include!' marco to include env 'OUT_DIR' proto rs .
And you needn't to create a dir in your source dir.

@Tim-Zhang
Copy link
Member

@jokemanfire The feature is useful, and I think we'd better not update the example because I occasionally need to check the generated code and out_dir is not easy to find. By the way, please take a look at the failed CI, thanks

@jokemanfire jokemanfire force-pushed the dev6 branch 3 times, most recently from dbda636 to ea662c5 Compare November 4, 2024 11:59
@jokemanfire
Copy link
Contributor Author

@jokemanfire The feature is useful, and I think we'd better not update the example because I occasionally need to check the generated code and out_dir is not easy to find. By the way, please take a look at the failed CI, thanks

Ok ,I've changed and add usage in doc.

ttrpc-codegen/src/lib.rs Outdated Show resolved Hide resolved
@Tim-Zhang
Copy link
Member

@jokemanfire I left a new comment, PTAL, thanks

@jokemanfire jokemanfire force-pushed the dev6 branch 2 times, most recently from 4199a48 to 5b5cbcd Compare December 25, 2024 09:46
@jokemanfire
Copy link
Contributor Author

jokemanfire commented Dec 25, 2024

@jokemanfire I left a new comment, PTAL, thanks

error: package `home v0.5.11` cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.77.0
Either upgrade to rustc 1.81 or newer, or use
cargo update home@0.5.11 --precise ver
where `ver` is the latest version of `home` supporting rustc 1.77.0
make: *** [Makefile:9: debug] Error 101

CI now have some problem need update rustc version ???
There 's no cargo lock so it may use the latest home package home v0.5.11 ,but it only support up v1.81 version rustc

@jokemanfire jokemanfire force-pushed the dev6 branch 4 times, most recently from 43fa5e8 to b50d83a Compare December 26, 2024 07:59
@Tim-Zhang
Copy link
Member

Tim-Zhang commented Dec 28, 2024

@jokemanfire After the pr #267 was merged, the rustc verstion problem has disappeared. Please rebase and remove the fix commit. thanks

@jokemanfire
Copy link
Contributor Author

@jokemanfire After the pr #267 was merged, the rustc verstion problem has disappeared. Please rebase and remove the fix commit. thanks

Ok I've update

@Tim-Zhang
Copy link
Member

@jokemanfire I left comments again. PTAL, thanks.

If not set out_dir,it will use env 'OUT_DIR',to generate proto rs file.
You can use 'include!' marco to include env 'OUT_DIR' proto rs .

Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
@teawater teawater merged commit 4a493e1 into containerd:master Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants