Fix compatibility with latest ttrpc and pin ttrpc version to 0.8.2 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
approved these changes
Oct 3, 2024
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
mxpv
changed the title
|
LGTM |
This was referenced Oct 3, 2024
|
I don't make sure if other libs is updated, we can build the same binary(same sha256). We should add some like go.sum to make sure we can replicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like new version of ttrpc introduces some backward incompatible changes (containerd/ttrpc-rust#235), this PR makes a few fixes in
shimandshim-protoscrates.cc: @Mossaka
ref: #317
Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com