Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build env to release job #375

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Oct 31, 2023

The release of containerd-shim-wasm crate failed at the cargo publish step saying that protoc was not found. Thus I am adding build env to the release job.

Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant
Copy link
Contributor

LGTM

Maybe as a follow up after this release we can run the release CI up to the Publishing steps so we can catch issues earlier?

@Mossaka
Copy link
Member Author

Mossaka commented Oct 31, 2023

LGTM

Maybe as a follow up after this release we can run the release CI up to the Publishing steps so we can catch issues earlier?

There is a nice flag for cargo publish --dry-run to run all the checks without uploading to crates.io. Is this what you meant?

@Mossaka Mossaka merged commit a13f12b into containerd:main Oct 31, 2023
43 checks passed
@jsturtevant
Copy link
Contributor

yes, if we can run that semi regularly then we could catch issues before release time?

@Mossaka Mossaka deleted the build-env branch October 31, 2023 19:24
@Mossaka
Copy link
Member Author

Mossaka commented Oct 31, 2023

yes, if we can run that semi regularly then we could catch issues before release time?

Maybe we should refactor the pipeline to an reusable action and run it at our build (with --dry-run flag on)

@Mossaka
Copy link
Member Author

Mossaka commented Nov 1, 2023

@jsturtevant just realized that --dry-run won't be able to catch errors like https://github.com/containerd/runwasi/actions/runs/6715767237/job/18251185616#step:7:794

See related discussion: rust-lang/cargo#5941

@jprendes
Copy link
Collaborator

jprendes commented Nov 1, 2023

It can still catch other issues, I think it's still worth adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants