Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(testing): go.mod: downgrade ttrpc to latest v1.1.x release #70

Closed
wants to merge 3 commits into from

Conversation

thaJeztah
Copy link
Member

downgrade the minimum required version to v1.1.1. consumers
of this module can pick higher versions to match their
requirements.

@thaJeztah
Copy link
Member Author

just testing if this would work 😅

This reverts commit 45b9e3f.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This reverts commit f600cf6.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Looks like we need v1.2.0 as a minimum (containerd/ttrpc@d28bc92 is v1.2.0 and up);

Error: pkg/api/api_ttrpc.pb.go:16:6: srv.RegisterService undefined (type *ttrpc.Server has no field or method RegisterService)
Error: pkg/api/api_ttrpc.pb.go:73:6: srv.RegisterService undefined (type *ttrpc.Server has no field or method RegisterService)
make: *** [Makefile:77: build-check] Error 1
Error: Process completed with exit code 2.

@thaJeztah
Copy link
Member Author

And I see v1.2.3 was tagged; https://github.com/containerd/ttrpc/releases/tag/v1.2.3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bac4892) 64.44% compared to head (ebf4ba0) 64.55%.

❗ Current head ebf4ba0 differs from pull request most recent head a38edc6. Consider uploading reports for the commit a38edc6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   64.44%   64.55%   +0.10%     
==========================================
  Files          10       10              
  Lines        1845     1845              
==========================================
+ Hits         1189     1191       +2     
+ Misses        505      503       -2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants