stub: pass context to plugins, pass updated resources to UpdateContainers. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 64.00% 64.50% +0.50%
==========================================
Files 9 9
Lines 1800 1800
==========================================
+ Hits 1152 1161 +9
+ Misses 497 493 -4
+ Partials 151 146 -5 ☔ View full report in Codecov by Sentry. |
klihub
force-pushed
the
fixes/plugin-stub-interface
branch
from
0067be5 to
e4a4790
Compare
mikebrow
reviewed
May 18, 2023
klihub
force-pushed
the
fixes/plugin-stub-interface
branch
from
e4a4790 to
81f7daf
Compare
klihub
changed the title
klihub
changed the title
klihub
changed the title
klihub
force-pushed
the
fixes/plugin-stub-interface
branch
2 times, most recently
from
7d2910a to
0ba9e87
Compare
Don't hide context from plugins, pass the corresponding context to each plugin handler. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Update mock plugin to implement the updated stub interfaces. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Update plugin event handlers with the updated stub interfaces. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/plugin-stub-interface
branch
from
0ba9e87 to
d65f23e
Compare
mikebrow
reviewed
May 23, 2023
Fix UpdateContainer adding an argument for the updated resources. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add basic tests for UpdateContainer using container creation tests as a starting point. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/plugin-stub-interface
branch
from
d65f23e to
01d5f14
Compare
Argh... Thanks for spotting that ! Fixed. |
|
***: requires version tag, and container runtime release notes (containerd/crio) for breaking api change when they vendor the next tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't hide the ttRPC request context from plugins. Pass the context on to the plugin's request handler. Once we have opentelemetry ttRPC instrumentation support, this should allow us to properly propagate trace spans and have detailed instrumentation on the plugins side properly nested into the related original request on the runtime side.
While making API-breaking changes, also fix UpdateContainer adding an argument with the updated resources.
Update sample plugins and tests with the updated interfaces and add basic tests for UpdateContainer which we lacked so far.