-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run with pidfile option #311
Conversation
I think this time we are ready for the big moment @AkihiroSuda, this will be my first PR for the nerdctl and I'm so excited about this 🥳😋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this has to be implemented in pkg/ocihook
to support restarting like podman:
$ podman run -d --name foo --restart=always --pidfile /tmp/foo.pid nginx:alpine
$ cat /tmp/foo.pid
41021
$ kill -9 41021
$ cat /tmp/foo.pid
41100
I did something about OCI hook for supporting |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
any updates @AkihiroSuda 🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and pushed a small fix
Sorry for my recent delay in reviewing PRs
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
I'm not so sure but It might fix the second option of issue #215.