Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerdctl-full: compile runc with CGO_ENABLED=1 #264

Merged
merged 1 commit into from
Jun 24, 2021
Merged

nerdctl-full: compile runc with CGO_ENABLED=1 #264

merged 1 commit into from
Jun 24, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda
nerdctl-full: compile runc with CGO_ENABLED=1
0a76339 
For opencontainers/runc issue 3037

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda requested a review from ktock June 24, 2021 08:14
@fahedouch
Copy link
Member

@AkihiroSuda do we really need to activate the GCO ? is it for cross-compiling needs? because it has many drawbacks like making the compilation slower and then slower build.

@AkihiroSuda
Copy link
Member Author

Yes, we really need, for enabling seccomp.

@AkihiroSuda AkihiroSuda merged commit 1ac4468 into containerd:master Jun 24, 2021
@AkihiroSuda AkihiroSuda added this to the v0.10.0 milestone Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktock ktock ktock approved these changes

Assignees
No one assigned
Labels
impact/major
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @fahedouch @ktock