fix copying up initial contents of the mount point directory #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
fix-copying-up-initial-content
branch
2 times, most recently
from
a5244a2
to
e6f5512
Compare
|
Thanks, can we have tests? |
AkihiroSuda
reviewed
Jun 24, 2021
run_mount_test.go
Outdated
| base.Cmd("run", "-v", "/mnt", "--rm", imageName).AssertOutContains("hi") | ||
|
|
||
| //NamedVolume | ||
| base.Cmd("volume", "create", "copying-initial-content").AssertOK() |
There was a problem hiding this comment.
The volume should be created automatically to fix #262
Can be another PR, though
There was a problem hiding this comment.
I did both @AkihiroSuda
fahedouch
force-pushed
the
fix-copying-up-initial-content
branch
3 times, most recently
from
25d8211
to
530f3c1
Compare
AkihiroSuda
reviewed
Jun 25, 2021
pkg/mountutil/mountutil.go
Outdated
| @@ -67,7 +68,14 @@ func ProcessFlagV(s string, volStore volumestore.VolumeStore) (*Processed, error | |||
| // assume src is a volume name | |||
| vol, err := volStore.Get(src) | |||
| if err != nil { | |||
| return nil, err | |||
| if strings.Contains(err.Error(), errdefs.ErrNotFound.Error()) { | |||
fahedouch
force-pushed
the
fix-copying-up-initial-content
branch
from
e8d8a66
to
e458a63
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
fix-copying-up-initial-content
branch
from
e458a63
to
e986355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copying up initial contents of the mount point directory when using
-vflagautomatically create not found volumes
fixing #262
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com