Fix compose lacking support for replicas = 0 #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
force-pushed
the
fix-compose-lacking-support-for-replicas-0
branch
2 times, most recently
from
29fde9b
to
87ff829
Compare
|
Suggest adding a test case under https://github.com/containerd/nerdctl/blob/main/pkg/composer/serviceparser/serviceparser_test.go to cover the scenario. |
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
fix-compose-lacking-support-for-replicas-0
branch
from
87ff829
to
f8a8295
Compare
ningziwen
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the compose service replica set to 0.
fix #2223