Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade indirect dependancy go-libp2p-core v0.8.6 to go-libp2p-core v0.20.1 to remove indirect dependacy of btcd module which is vulnerable to CVE-2022-44797 #1625

Conversation

bsalunke
Copy link
Contributor

@bsalunke bsalunke commented Dec 8, 2022

Upgrade indirect dependancy go-libp2p-core v0.8.6 to go-libp2p-core v0.20.1 to remove indirect dependacy of btcd module which is vulnerable to CVE-2022-44797

What is it fixing
Nerdctl has an indirect dependency module ("github.com/btcsuite/btcd v0.21.0-beta) having vulnerability reported https://nvd.nist.gov/vuln/detail/CVE-2022-44797.

As explained by @AkihiroSuda, it's false positive and nerdctl does not trigger the code path in any way to invoke "btcd" module. The fix provided was VEX set to eliminate #1571

However APIK some of the open source scanner does not support VEX as of today. e.g. aquasecurity/trivy#1836.

Fix
Upgrade indirect dependancy go-libp2p-core v0.8.6 to go-libp2p-core v0.20.1

Please let me know if more information needs to be added.

…0.20.1 to remove indirect dependacy of btcd module which is vulnerable to CVE-2022-44797
@djdongjin
Copy link
Member

Hi @bsalunke please sign your commit

@bsalunke bsalunke closed this Dec 8, 2022
@bsalunke
Copy link
Contributor Author

bsalunke commented Dec 8, 2022

Thanks @djdongjin. Created another PR with sign: #1626.

Closing this as not required.

@djdongjin
Copy link
Member

just fyi, you can also git commit --amend -s (and git push -f) to sign an existing commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants