Add compose pause and unpause commands #1621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the two commands in the same file and all logic on the
cmd/nerdctl
side (no logic inpkg/composer
) because:pauseContainer
andunpauseContainer
which are incmd
and we don't wantpkg
to rely oncmd
. (Or maybe we can move all to their relatedpkg
s).(un)pause
) and they're usually used together.The current implementation follows docker compose behavior, which parallelizes
(un)pause services
and stops whenever there is an error, causing the result in an intermediate state (some services are paused and some are not, depending on the parallelization). As an example:Signed-off-by: Jin Dong jindon@amazon.com