nerdctl wait command #162
Merged
nerdctl wait command #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
requested changes
Apr 12, 2021
container_wait.go
Outdated
| walker := &containerwalker.ContainerWalker{ | ||
| Client: client, | ||
| OnFound: func(ctx context.Context, found containerwalker.Found) error { | ||
| if err := waitContainer(clicontext, ctx, client, found.Container.ID()); err != nil { |
There was a problem hiding this comment.
nerdctl wait foo bar may not be able to print the status of bar when bar exits and gets removed before foo exits.
So task.Wait() should be called in goroutines.
|
Could you also update README (https://github.com/containerd/nerdctl#unimplemented-docker-commands) ? |
@AkihiroSuda if all is ok then I will squash commit! |
AkihiroSuda
requested changes
Apr 12, 2021
AkihiroSuda
reviewed
Apr 13, 2021
AkihiroSuda
reviewed
Apr 13, 2021
AkihiroSuda
reviewed
Apr 13, 2021
AkihiroSuda
reviewed
Apr 13, 2021
AkihiroSuda
reviewed
Apr 13, 2021
AkihiroSuda
reviewed
Apr 13, 2021
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com