Add compose restart command
#1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 22, 2022
pkg/composer/restart.go
Outdated
| // RestartOptions stores all option input from `nerdctl compose restart` | ||
| type RestartOptions struct { | ||
| TimeChanged bool | ||
| Timeout uint |
There was a problem hiding this comment.
Can we remove TimeChanged by checking Timeout > 0, or Timeout != nil ?
There was a problem hiding this comment.
Thanks for the suggestion. Changed to use a *uint in both compose restart and compose stop so nil can be used to check if timeout is passed or not.
djdongjin
force-pushed
the
compose-restart
branch
4 times, most recently
from
48ab5ce
to
4b18ce5
Compare
Signed-off-by: Jin Dong <jindon@amazon.com>
Signed-off-by: Jin Dong <jindon@amazon.com>
djdongjin
force-pushed
the
compose-restart
branch
from
4b18ce5
to
671be9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1494, this one adds
nerdctl compose restartcommand. It's done by callingnerdctl restart CONTAINER_IDfor each service containers.Signed-off-by: Jin Dong jindon@amazon.com