rootless: fix CONTAINERD_ROOTLESS_ROOTLESSKIT_PORT_DRIVER=slirp4netns #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…ns port driver Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…t driver Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-slirp4netns
branch
from
54f9ade
to
6f987c6
Compare
AkihiroSuda
changed the title
AkihiroSuda
force-pushed
the
fix-slirp4netns
branch
3 times, most recently
from
f9c792c
to
2949e3a
Compare
…irp4netns Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-slirp4netns
branch
from
2949e3a
to
52b87a4
Compare
ktock
reviewed
Mar 30, 2021
| // this is fine | ||
| } else { | ||
| if portDriverDisallowsLoopbackChildIP { | ||
| p.HostIP = childIP.String() |
There was a problem hiding this comment.
Is it OK that childIP == nil enters this case?
There was a problem hiding this comment.
Can’t be nil when portDriverDisallowsLoopbackChildIP is true
| // For rootless, we need to modify the hostIP that is not bindable in the child namespace. | ||
| // https: //github.com/containerd/nerdctl/issues/88 | ||
| // | ||
| // We must NOT modify opts.ports here, because we use the unmodified opts.ports for | ||
| // interaction with RootlessKit API. | ||
| ports := make([]cni.PortMapping, len(opts.ports)) | ||
| for i, p := range opts.ports { | ||
| if hostIP := net.ParseIP(p.HostIP); hostIP != nil { | ||
| if hostIP := net.ParseIP(p.HostIP); hostIP != nil && !hostIP.IsUnspecified() { | ||
| // loopback address is always bindable in the child namespace, but other addresses are unlikely. |
There was a problem hiding this comment.
nit:
not always bindable? (i.e. loopback is not bindable when portDriverDisallowsLoopbackChildIP == true?)
There was a problem hiding this comment.
Bindable but not forwardable
ktock
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.