Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sysx] add ppc64le and s390x copyfilerange targets #91

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

tophj-ibm
Copy link
Contributor

This adds ppc64le and s390x targets in the generate script in sysx, and generates them.

This should fix building / running tests for us on containerd.

The SYS_COPY_FILE_RANGE values were all taken from golang.org/x/sys.

Signed-off-by: Christopher Jones tophj@linux.vnet.ibm.com

This adds ppc64le and s390x targets in the generate script.

Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>
@dmcgowan
Copy link
Member

Thanks, I forgot about this function. It has been upstreamed to golang.org/x/sys/unix and could be removed here, after containerd switches to no longer call it. Let's merge this now but I would prefer to see the update to containerd use the upstream package then delete it here.

@dmcgowan
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 4e9812d into containerd:master Jul 25, 2017
@tophj-ibm tophj-ibm deleted the ppc64le-s390x-copy-syscalls branch July 26, 2017 12:07
@estesp estesp mentioned this pull request Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants